Tried to adjust it as per needed options. #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I will have to get the CI config updated first 😊 |
Contributor
Author
|
I just checked another site on that server same thing I wonder, could we add a cache behind it? and it would just fetch from that (redis) result, so that there is actually 0 file lookups for this? |
Contributor
Author
|
I just checked/tested, this reduces it to 0 file lookups once the config has been built. |
markstory
added a commit
that referenced
this pull request
Apr 25, 2025
Owner
|
Getting the build fixed in #375 |
Owner
|
I've got the build fixed for 4.x, but there are still a few failing tests here. |
Contributor
Author
|
Those are some ideas. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.x #374 +/- ##
============================================
- Coverage 92.39% 91.98% -0.41%
- Complexity 116 124 +8
============================================
Files 10 10
Lines 368 387 +19
============================================
+ Hits 340 356 +16
- Misses 28 31 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I made the cache configurable, defaulting to debug mode setting. Lots of deprecations, but otherwise seems fine: |
dereuromark
commented
Apr 30, 2025
| $cache = 'default'; | ||
| } | ||
| if ($cache) { | ||
| $cachedConfig = Cache::read('asset_compress_config', $cache); |
Contributor
Author
There was a problem hiding this comment.
should the cache key be dependent on the args path and skipPlugins maybe?
Owner
There was a problem hiding this comment.
I don't think that is necessary. I'd like to learn more about the use case before exposing that.
Being able to have the helper load specific paths is useful for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin could need a bit more love I guess
Only show-casing for now what would be needed to get things working in a "cake" way
Refs #373
notes: